Skip to content

[PM-36045] Fix application of bitLink selector in desktop usages#20494

Open
vleague2 wants to merge 1 commit intomainfrom
uif/pm-36045/bitlink-selector-desktop
Open

[PM-36045] Fix application of bitLink selector in desktop usages#20494
vleague2 wants to merge 1 commit intomainfrom
uif/pm-36045/bitlink-selector-desktop

Conversation

@vleague2
Copy link
Copy Markdown
Contributor

@vleague2 vleague2 commented May 4, 2026

🎟️ Tracking

PM-36045

📔 Objective

The password generator dialog in the desktop "edit cipher" page was not opening properly and was therefore not accessible to screenreaders. The root cause ended up being that there were two Angular component selectors applied to one element inside of the dialog, which is not supported. (The bitLink component recently updated from directive to component, so previously this worked but was not common to do.) This PR removes the bitLink selector from the affected element and also from one other instance that had the same problem. In both cases, bitLink was unnecessary (in the fido2 case, because the child element is also a bitLink; in the generator case, removing the bitLink styles will now match the existing browser/web styles).

📸 Screenshots

Before:

Screen.Recording.2026-05-04.at.12.02.45.PM.mov

After:

screencap.mp4

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.11%. Comparing base (3213690) to head (7aeeb26).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20494      +/-   ##
==========================================
+ Coverage   47.10%   47.11%   +0.01%     
==========================================
  Files        3948     3950       +2     
  Lines      119688   119725      +37     
  Branches    18344    18348       +4     
==========================================
+ Hits        56374    56406      +32     
- Misses      59080    59083       +3     
- Partials     4234     4236       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vleague2 vleague2 marked this pull request as ready for review May 5, 2026 16:44
@vleague2 vleague2 requested review from a team as code owners May 5, 2026 16:44
@vleague2 vleague2 requested a review from gbubemismith May 5, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant