Small fix for ssh namespace mismatch#20502
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20502 +/- ##
=======================================
Coverage 47.11% 47.11%
=======================================
Files 3951 3951
Lines 119732 119732
Branches 18349 18349
=======================================
Hits 56410 56410
Misses 59086 59086
Partials 4236 4236 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR fixes the v1/v2 SSH agent namespace casing mismatch by switching the napi-rs string enum to camelCase serialization ( Code Review DetailsNo findings. |
|



🎟️ Tracking
None
📔 Objective
This PR aims to fix a potential case mismatch in the ssh agent v1 and v2 "namespace" implementations. It may not be accurate, but here is the concept:
Line 59 of
clients/apps/desktop/src/autofill/components/approve-ssh-request.tschecks the namespace string, currently matching on"git"for v1. However, v2'sSIGNamespace.Gitenum variant fromclients/apps/desktop/desktop_native/napi/src/sshagent_v2.rsends up being"Git", according to line 308 inclients/apps/desktop/desktop_native/napi/index.d.ts."Git"won't match here, soactioni18nKeywill end up being"sshActionSign", rather than"sshActionGitSign".There may be a better way to fix this, or this may be the intended behavior, and this PR is not needed. Just throwing this PR up as a starting point for conversation, and as a potential fix.
If the bug identified is accurate, then we'll want to verify this doesn't break anything on the ssh v1 side.