Skip to content

[PM-34832] Update event logging messages for account recovery #20512

Open
JaredScar wants to merge 1 commit intomainfrom
ac/pm-34832-event-logs-text-not-updated
Open

[PM-34832] Update event logging messages for account recovery #20512
JaredScar wants to merge 1 commit intomainfrom
ac/pm-34832-event-logs-text-not-updated

Conversation

@JaredScar
Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34832

📔 Objective

Changes messages for event logs in messages.json

@JaredScar JaredScar requested a review from a team as a code owner May 5, 2026 17:55
@JaredScar JaredScar added the ai-review Request a Claude code review label May 5, 2026
@JaredScar JaredScar requested a review from eliykat May 5, 2026 17:55
@JaredScar JaredScar self-assigned this May 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR renames three i18n message keys (and their English values) to use clearer "account recovery" terminology, and updates the corresponding lookups in apps/web/src/app/dirt/event-logs/services/event.service.ts. The change is a pure string-and-key rename with no behavior or logic change. New keys resolve correctly in apps/web/src/locales/en/messages.json, and no other code or test references the old keys. Non-English locale files still reference the old keys, which is the expected workflow — translations are managed through Crowdin and will sync asynchronously, with English as the fallback in the meantime.

Code Review Details

No findings.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 5, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.11%. Comparing base (afd36d2) to head (7929554).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../src/app/dirt/event-logs/services/event.service.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20512      +/-   ##
==========================================
- Coverage   47.11%   47.11%   -0.01%     
==========================================
  Files        3951     3951              
  Lines      119754   119754              
  Branches    18349    18349              
==========================================
- Hits        56424    56422       -2     
- Misses      59096    59098       +2     
  Partials     4234     4234              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant