[CL-1186] - spotlight and popover fixes#20519
Open
jaasen-livefront wants to merge 2 commits intomainfrom
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



🎟️ Tracking
https://bitwarden.atlassian.net/browse/CL-1186
📔 Objective
Fixes issues with the spotlight effect used in guided tour popovers, and adds customization inputs to
bit-popover.Light mode contrast — The spotlight overlay opacity was
0.3, too close to the nav hover color to create visible contrast. Increased to0.55.Resize lag — CDK's
repositionscroll strategy only reacts to scroll events, so resizing the window caused the spotlight cutout to trail behind the highlighted element. Added awindowresizelistener inSpotlightServicethat immediately callsupdatePosition(), cleaned up when the overlay is disposed.Spotlight cropping — The spotlight cutout was sizing to the directive's host element, which could be wider than the visual target (e.g. a full-width nav row). Added a
spotlightTargetSelectorinput toPopoverAnchorForDirectivethat accepts a CSS selector to find a child element to use as the spotlight target instead.Viewport margin — Added a
viewportMargininput toPopoverAnchorForDirectiveto control the minimum distance between the popover and the viewport edge (passed to CDK'swithViewportMargin()).Popover customization — Added optional
panelClass,headerClass,titleClass, andcontentClassinputs tobit-popoverfor overriding styles on specific sections without modifying the shared component defaults.📸 Screenshots
Screen.Recording.2026-05-05.at.2.18.15.PM.mov