Skip to content

[PM-36609] Add regex manager for updating electronVersion on electron updates#20520

Open
trmartin4 wants to merge 1 commit intomainfrom
platform/electronbuilder-update
Open

[PM-36609] Add regex manager for updating electronVersion on electron updates#20520
trmartin4 wants to merge 1 commit intomainfrom
platform/electronbuilder-update

Conversation

@trmartin4
Copy link
Copy Markdown
Member

@trmartin4 trmartin4 commented May 6, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-36609

📔 Objective

We currently have to manually update the electron-builder.json electronVersion for each electron update.

This PR adds in a custom regex manager to look in electron-builder.json and update the version when electron updates.

This is similar to what we do for the Rust toolchain update already.

@trmartin4 trmartin4 added the ai-review Request a Claude code review label May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Adds a Renovate custom regex manager to keep electronVersion in apps/desktop/electron-builder.json synchronized with the electron npm package. The change pairs cleanly with the existing CI verification in .github/workflows/build-desktop.yml (lines 63-73) that fails the build when these versions diverge, so automating the bump is a sound reliability improvement. The regex ("electronVersion":\s*"(?<currentValue>[\d.]+)"), the fileMatch anchor that correctly excludes electron-builder.beta.json, and the npm datasource with depName: electron all check out. Future PRs raised by this manager will be picked up by the existing electron group rule (lines 471-481) alongside electron-builder/electron-updater.

Code Review Details

No findings.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@trmartin4 trmartin4 changed the title Added regex manager for updating electronVersion. Add regex manager for updating electronVersion on electron updates May 6, 2026
@trmartin4 trmartin4 changed the title Add regex manager for updating electronVersion on electron updates [PM-36609] Add regex manager for updating electronVersion on electron updates May 6, 2026
@trmartin4 trmartin4 marked this pull request as ready for review May 6, 2026 02:01
@trmartin4 trmartin4 requested a review from dani-garcia May 6, 2026 02:01
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.01%. Comparing base (72f082b) to head (1446d41).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20520      +/-   ##
==========================================
- Coverage   47.02%   47.01%   -0.01%     
==========================================
  Files        3951     3951              
  Lines      119648   119648              
  Branches    18325    18325              
==========================================
- Hits        56265    56257       -8     
- Misses      59141    59150       +9     
+ Partials     4242     4241       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant