Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SM-949] Add Event Logs to Service Account #6546

Merged
merged 12 commits into from
Oct 19, 2023
Merged

[SM-949] Add Event Logs to Service Account #6546

merged 12 commits into from
Oct 19, 2023

Conversation

differsthecat
Copy link
Member

@differsthecat differsthecat commented Oct 10, 2023 •
edited
Loading

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Add Event Logs tab to Service Accounts
Relies on this server PR

Code changes

  • bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/event-logs/service-account-event-log-api.service.ts: Add service account event logs API service
  • bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/event-logs/service-accounts-events.component.html: Add Component
  • bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/event-logs/service-accounts-events.component.ts: Add Component that extends BaseEventsComponent
  • bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/service-account.component.html: Add Event Logs tab link
  • bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/service-accounts-routing.module.ts: Add Event logs route
  • bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/service-accounts.module.ts: Add new component to the Service Accounts module

Screenshots

ServiceAccountLogs.mov

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Oct 10, 2023
@bitwarden-bot
Copy link

bitwarden-bot commented Oct 10, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 0a2f3491-cdf2-4f75-b667-a688e8581e55

No New Or Fixed Issues Found

Thomas-Avery
Thomas-Avery requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

One minor thing to take a look at.

...web/src/app/secrets-manager/service-accounts/event-logs/service-accounts-events.component.ts Outdated Show resolved Hide resolved
differsthecat and others added 2 commits October 10, 2023 13:23
@differsthecat @Thomas-Avery
Update bitwarden_license/bit-web/src/app/secrets-manager/service-acco…
bbdad6f 
…unts/event-logs/service-accounts-events.component.ts

Co-authored-by: Thomas Avery <[email protected]>
@differsthecat
Add takeUntil import
1056495
@differsthecat differsthecat marked this pull request as ready for review October 10, 2023 17:27
@differsthecat differsthecat requested a review from a team as a code owner October 10, 2023 17:27
Thomas-Avery
Thomas-Avery previously approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Thomas-Avery Thomas-Avery requested a review from a team October 18, 2023 20:54
coltonhurst
coltonhurst approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@coltonhurst coltonhurst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @differsthecat and @Thomas-Avery

@Thomas-Avery Thomas-Avery removed the needs-qa Marks a PR as requiring QA approval label Oct 19, 2023
@Thomas-Avery Thomas-Avery merged commit e9f0c07 into master Oct 19, 2023
4 checks passed
@Thomas-Avery Thomas-Avery deleted the sm/sm-949-service-account-event-logs branch October 19, 2023 21:56
BlackDex pushed a commit to BlackDex/bitwarden-clients that referenced this pull request Nov 21, 2023
@differsthecat @Thomas-Avery @BlackDex
[SM-949] Add Event Logs to Service Account (bitwarden#6546)
d273d7d 
* Add Event Logs to Service Account

* Update bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/event-logs/service-accounts-events.component.ts

Co-authored-by: Thomas Avery <[email protected]>

* Add takeUntil import

* add service account access guard

---------

Co-authored-by: Thomas Avery <[email protected]>
Co-authored-by: Thomas Avery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coltonhurst coltonhurst coltonhurst approved these changes

@Thomas-Avery Thomas-Avery Thomas-Avery left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@differsthecat @bitwarden-bot @coltonhurst @Thomas-Avery