Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update client arch docs for team-owned libs #259

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

update client arch docs for team-owned libs #259

wants to merge 9 commits into from

Conversation

willmartian
Copy link

@willmartian willmartian commented Dec 15, 2023 •
edited
Loading

Objective

Update the web client architecture docs to describe our approach to team-owned libs.

@willmartian willmartian requested review from a team as code owners December 15, 2023 15:59
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 15, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b09ccc7
Status: ✅  Deploy successful!
Preview URL: https://93c678c7.contributing-docs.pages.dev
Branch Preview URL: https://team-owned-libs-docs.contributing-docs.pages.dev

View logs

@willmartian willmartian requested a review from Hinton December 15, 2023 16:06
withinfocus
withinfocus reviewed Dec 15, 2023
View reviewed changes
custom-words.txt Outdated Show resolved Hide resolved
withinfocus
withinfocus reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more thoughts. Would still like Gibson or Oscar to take a read.

docs/architecture/clients/index.md Outdated Show resolved Hide resolved
docs/architecture/clients/index.md Outdated Show resolved Hide resolved
docs/architecture/clients/index.md Outdated Show resolved Hide resolved
withinfocus
withinfocus reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good from my perspective.

docs/architecture/clients/index.md Outdated Show resolved Hide resolved
withinfocus
withinfocus reviewed Dec 18, 2023
View reviewed changes
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint, but this seems good.

@willmartian willmartian force-pushed the team-owned-libs-docs branch from 6d4c07d to bfba1fe Compare January 9, 2024 14:57
@willmartian willmartian marked this pull request as draft January 9, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@withinfocus withinfocus withinfocus left review comments

@JaredSnider-Bitwarden JaredSnider-Bitwarden Awaiting requested review from JaredSnider-Bitwarden

@Hinton Hinton Awaiting requested review from Hinton

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@willmartian @Hinton @withinfocus @JaredSnider-Bitwarden