Skip to content

Add initial credential-exchange-types#2

Merged
Hinton merged 3 commits intomainfrom
types
Oct 10, 2024
Merged

Add initial credential-exchange-types#2
Hinton merged 3 commits intomainfrom
types

Conversation

@Hinton
Copy link
Copy Markdown
Member

@Hinton Hinton commented Oct 10, 2024

📔 Objective

Add the initial credential-exchange-types from the specification.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested review from abergs and dani-garcia October 10, 2024 08:52
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 10, 2024

Logo
Checkmarx One – Scan Summary & Details517add85-2e5c-470d-aee4-905f8efdde6f

No New Or Fixed Issues Found

Copy link
Copy Markdown
Member

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hinton Hinton merged commit ec78b45 into main Oct 10, 2024
@Hinton Hinton deleted the types branch September 8, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants