Skip to content

Change creation and modified dates of item to optional#33

Merged
Hinton merged 1 commit intomainfrom
optional-item
Dec 9, 2024
Merged

Change creation and modified dates of item to optional#33
Hinton merged 1 commit intomainfrom
optional-item

Conversation

@Hinton
Copy link
Copy Markdown
Member

@Hinton Hinton commented Dec 9, 2024

📔 Objective

The creation_at and modified_at fields for Item are now optional in the spec.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from dani-garcia December 9, 2024 10:38
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 9, 2024

Logo
Checkmarx One – Scan Summary & Detailsae1a789a-f43a-4089-adee-31ef4f67566e

No New Or Fixed Issues Found

@Hinton Hinton merged commit 1ac7709 into main Dec 9, 2024
@Hinton Hinton deleted the optional-item branch December 9, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants