Skip to content

[BRE-831] migrate secrets AKV#78

Merged
pixman20 merged 7 commits into
mainfrom
BRE-831-migrate-secrets-akv
Jul 9, 2025
Merged

[BRE-831] migrate secrets AKV#78
pixman20 merged 7 commits into
mainfrom
BRE-831-migrate-secrets-akv

Conversation

@pixman20

@pixman20 pixman20 commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

🎟️ Tracking

BRE-831

📔 Objective

Updating to use Azure Key Vault Secrets in place of GitHub secrets.
All GitHub secrets have been migrated to the repository's respective Key Vault.
Azure Service Principals have been updated to use Managed Identities with OIDC.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions

github-actions Bot commented Jun 12, 2025

Copy link
Copy Markdown

Logo
Checkmarx One – Scan Summary & Detailsd360e0cd-add8-4eea-b8dc-3786d8751c2a

Great job, no security vulnerabilities found in this Pull Request

@pixman20 pixman20 marked this pull request as ready for review June 26, 2025 22:37
@pixman20 pixman20 requested a review from vgrassia June 26, 2025 22:38
Comment thread .github/workflows/publish.yml Outdated
Comment thread .github/workflows/scan.yml Outdated
Comment thread .github/workflows/scan.yml Outdated
Comment thread .github/workflows/version-bump.yml Outdated
@pixman20 pixman20 requested a review from vgrassia July 1, 2025 03:38
@pixman20 pixman20 merged commit 6c171fc into main Jul 9, 2025
7 checks passed
@pixman20 pixman20 deleted the BRE-831-migrate-secrets-akv branch July 9, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants