Skip to content

BRE-264 - Update build workflow to use API key for App Store Connect#566

Merged
vgrassia merged 1 commit intomainfrom
bre-264_update-workflows-for-app-store
Aug 26, 2024
Merged

BRE-264 - Update build workflow to use API key for App Store Connect#566
vgrassia merged 1 commit intomainfrom
bre-264_update-workflows-for-app-store

Conversation

@vgrassia
Copy link
Copy Markdown
Member

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR update the build workflow to use an API key for App Store Connect.

Code changes

  • .github/workflows/build.yml: Add setup for private auth key and update environment variables for building application
  • scripts/notarize.js: Update logic to use API key if environment variables are set.

@vgrassia vgrassia self-assigned this Aug 21, 2024
@vgrassia vgrassia requested a review from a team as a code owner August 21, 2024 16:06
@vgrassia vgrassia requested review from a team and addisonbeck August 21, 2024 16:06
@vgrassia vgrassia enabled auto-merge (squash) August 21, 2024 16:07
@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb3cdaf3f-83f3-4c00-b4ff-07a4a59a911f

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 649 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Use_Of_Hardcoded_Password /scripts/notarize.js: 26 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 641
LOW Use_Of_Hardcoded_Password /scripts/notarize.js: 11

@vgrassia vgrassia merged commit 14314a3 into main Aug 26, 2024
@vgrassia vgrassia deleted the bre-264_update-workflows-for-app-store branch August 26, 2024 15:49
sso-bitwarden pushed a commit to sso-bitwarden/directory-connector that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants