Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-141 Refactor Release workflow to split deploy/publish steps #567

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

urbinaalex17
Copy link
Contributor

@urbinaalex17 urbinaalex17 commented Aug 30, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (BRE)
  • Other

Objective

Split directory-connector GitHub Release from Deploy/Publish.

Code changes

  • .github/workflows/release.yml: Remove deploy/publish steps.
  • .github/workflows/publish.yml: Create new workflow with removed steps from release.yml

Screenshots

Testing requirements

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@urbinaalex17 urbinaalex17 requested a review from a team as a code owner August 30, 2024 16:19
Copy link
Contributor

github-actions bot commented Aug 30, 2024

Logo
Checkmarx One – Scan Summary & Details1ab1872b-bd4b-40ce-a046-339e0f520885

No New Or Fixed Issues Found

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (1951b95) to head (7d5f4f6).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #567   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         56      56           
  Lines       2534    2534           
  Branches     462     462           
=====================================
  Misses      2534    2534           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/release.yml Outdated Show resolved Hide resolved
@urbinaalex17 urbinaalex17 enabled auto-merge (squash) September 4, 2024 16:29
Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a lot of background for this change, but it looks like Github Deployments aren't really relevant to directory-connector because it's a downloadable app only (not hosted anywhere).

@urbinaalex17 urbinaalex17 merged commit c973d5f into main Sep 5, 2024
20 checks passed
@urbinaalex17 urbinaalex17 deleted the task/BRE-141 branch September 5, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants