-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove npm minor grouping from renovate config #576
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 56 56
Lines 2552 2552
Branches 462 462
=====================================
Misses 2552 2552 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have it correct -- just remove that group and these will come in individually. I am not sure we do this for NPM anywhere else, but those projects are more-aggressively merged.
.github/renovate.json
Outdated
@@ -1,17 +1,12 @@ | |||
{ | |||
"$schema": "https://docs.renovatebot.com/renovate-schema.json", | |||
"extends": ["github>bitwarden/renovate-config"], | |||
"enabledManagers": ["github-actions", "npm"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ This removes NPM updates altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
@withinfocus to clarify, renovate should automatically detect the updated config, close the existing PR, and open the new PRs? |
It'll run again when the config changes, but it might not necessarily make new PRs given the schedule. That's easily worked around there where you just ask for PR creation via the checkboxes at #303. |
Type of change
Objective
The renovate config in this repository groups patch and minor updates together. I think this is unhelpful as it has led to this enormous PR (which is failing): #353.
I'd rather smaller, easier PRs, even if we have many of them. We don't use this grouping in
clients
either.The proposal here is to remove this grouping (this PR) and then force renovate to create new update PRs for each dependency (not sure how to do this - @withinfocus?).
@withinfocus renovate is your area, do you have any feedback on this approach?
@bitwarden/team-admin-console-dev this is going to affect the team, so feedback welcome.
Code changes
Screenshots
Testing requirements
Before you submit
npm run lint
) (required)