Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove npm minor grouping from renovate config #576

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Sep 2, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The renovate config in this repository groups patch and minor updates together. I think this is unhelpful as it has led to this enormous PR (which is failing): #353.

I'd rather smaller, easier PRs, even if we have many of them. We don't use this grouping in clients either.

The proposal here is to remove this grouping (this PR) and then force renovate to create new update PRs for each dependency (not sure how to do this - @withinfocus?).

@withinfocus renovate is your area, do you have any feedback on this approach?

@bitwarden/team-admin-console-dev this is going to affect the team, so feedback welcome.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Testing requirements

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@eliykat eliykat requested a review from a team as a code owner September 2, 2024 04:21
@eliykat eliykat requested a review from r-tome September 2, 2024 04:21
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (f47806d) to head (fd0b2a8).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #576   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         56      56           
  Lines       2552    2552           
  Branches     462     462           
=====================================
  Misses      2552    2552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Logo
Checkmarx One – Scan Summary & Details472941f0-d01e-4ba3-bb26-69a0ce0bf1da

No New Or Fixed Issues Found

@eliykat eliykat requested a review from withinfocus September 2, 2024 04:37
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have it correct -- just remove that group and these will come in individually. I am not sure we do this for NPM anywhere else, but those projects are more-aggressively merged.

@@ -1,17 +1,12 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": ["github>bitwarden/renovate-config"],
"enabledManagers": ["github-actions", "npm"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ This removes NPM updates altogether.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@eliykat eliykat requested a review from withinfocus September 4, 2024 00:01
@eliykat
Copy link
Member Author

eliykat commented Sep 4, 2024

@withinfocus to clarify, renovate should automatically detect the updated config, close the existing PR, and open the new PRs?

@withinfocus
Copy link
Contributor

@withinfocus to clarify, renovate should automatically detect the updated config, close the existing PR, and open the new PRs?

It'll run again when the config changes, but it might not necessarily make new PRs given the schedule. That's easily worked around there where you just ask for PR creation via the checkboxes at #303.

@eliykat eliykat merged commit 21cecc3 into main Sep 4, 2024
20 checks passed
@eliykat eliykat deleted the renovate-remove-minor-grouping branch September 4, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants