-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-3043] Refactor AuthService to only use organization api key login #622
[AC-3043] Refactor AuthService to only use organization api key login #622
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
========================================
+ Coverage 1.20% 2.48% +1.28%
========================================
Files 59 59
Lines 2572 2573 +1
Branches 466 467 +1
========================================
+ Hits 31 64 +33
+ Misses 2541 2509 -32 ☔ View full report in Codecov by Sentry. |
Fixed Issues
|
c5c191d
to
55253c4
Compare
🎟️ Tracking
https://bitwarden.atlassian.net/browse/AC-3043
📔 Objective
AuthService
supports multiple login methods viaLogInStrategy
s, including password, SSO, personal api key, etc. This is from old jslib code which was used by multiple clients.This PR:
OrganizationLoginStrategy
into theLoginStrategy
base classLoginStrategy
to remove unused codeLoginStrategy
class intoAuthService
- resulting in a single login method that just does the work itselfThe refactoring steps are easier to follow if you review commit-by-commit.
Depends on #621 being merged first.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes