[PM-15283] [PM-15284] [PM-15286] Upgrade Angular to 19. #692
+4,344
−2,927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #692 +/- ##
=====================================
Coverage 2.24% 2.24%
=====================================
Files 60 60
Lines 2633 2633
Branches 467 467
=====================================
Hits 59 59
Misses 2571 2571
Partials 3 3 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
|
We're holding off on this upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15286
https://bitwarden.atlassian.net/browse/PM-15284
https://bitwarden.atlassian.net/browse/PM-15283
📔 Objective
There were three Renovate PRs that failed because the dependencies relied on each other. I pulled down all the changes locally and resolved the missing dependencies, including TypeScript and Zone.js, which were not included in the Renovate PRs.
I ran an npm install, and all dependencies were successfully installed. I created this PR to ensure all quality gates pass as well.
Renovate PRs
#680
#679
#678
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes