Skip to content

Conversation

fntyler
Copy link
Contributor

@fntyler fntyler commented Sep 17, 2025

🎟️ Tracking

BRE-1158

📔 Objective

Include AppSec team and BRE dept for repository-level ownership of Dockerfile, and Dockerfile related, files.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.72%. Comparing base (e74546e) to head (984c33a).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #880   +/-   ##
=====================================
  Coverage   7.72%   7.72%           
=====================================
  Files         68      68           
  Lines       2757    2757           
  Branches     477     477           
=====================================
  Hits         213     213           
  Misses      2529    2529           
  Partials      15      15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Sep 17, 2025

Logo
Checkmarx One – Scan Summary & Details1275e20b-7f61-4b43-a6c4-60f2906aa233

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CVE-2025-10890 Npm-electron-38.1.0
detailsDescription: The google chrome version prior to 140.0.7339.207 is vulnerable to Side-channel information leakage in V8.
Attack Vector: NETWORK
Attack Complexity: HIGH

ID: H0vqcKL2e0ffUOtRO9BK3282%2FCK87AdbmJEH4e41dzI%3D
Vulnerable Package

@fntyler fntyler marked this pull request as ready for review September 17, 2025 20:12
@fntyler fntyler requested a review from a team as a code owner September 17, 2025 20:12
@fntyler fntyler requested a review from JimmyVo16 September 17, 2025 20:12
JimmyVo16
JimmyVo16 previously approved these changes Sep 18, 2025
Copy link

@fntyler fntyler enabled auto-merge (squash) September 29, 2025 19:22
@fntyler fntyler requested a review from JimmyVo16 September 29, 2025 19:22
@fntyler fntyler merged commit a259de8 into main Sep 30, 2025
18 checks passed
@fntyler fntyler deleted the bre/bre-1158/co-dockerfiles branch September 30, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants