Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Matt Bishop <[email protected]>
  • Loading branch information
justindbaur and withinfocus authored Dec 4, 2024
1 parent 343a2c7 commit b09057e
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ env:

jobs:
build-artifact:
name: Build Artifact
name: Build artifacts
runs-on: ubuntu-22.04
steps:
- name: Check out repo
Expand All @@ -38,7 +38,7 @@ jobs:
env:
IS_PRERELEASE: ${{ inputs.type == 'prerelease' }}

- name: Get Current Version
- name: Get current version
id: current-version
run: echo "VERSION=$(dotnet msbuild -p:IsPreRelease=$IS_PRERELEASE --getProperty:Version)"
env:
Expand All @@ -52,7 +52,7 @@ jobs:
const package = '${{ inputs.package }}';
const currentVersion = '${{ steps.current-version.outputs.VERSION }}';
// configure git
// Configure Git
await exec.exec(`git config user.name "github-actions"`);
await exec.exec(`git config user.email "[email protected]"`);
Expand Down Expand Up @@ -98,14 +98,14 @@ jobs:
console.log("Finished creating release.");
- name: Run Version Bumper
- name: Bump version
id: version-bumper
shell: pwsh
env:
PACKAGE_NAME: ${{ inputs.package }}
BUMP_TYPE: ${{ inputs.type }}
run: |
echo "NEW_VERSION=$(./scrips/UpdatePackageVersion.ps1 -PackageName $env:PACKAGE_NAME -BumpType $env:BUMP_TYPE)" >> $env:GITHUB_OUTPUT
echo "NEW_VERSION=$(./scripts/UpdatePackageVersion.ps1 -PackageName $env:PACKAGE_NAME -BumpType $env:BUMP_TYPE)" >> $env:GITHUB_OUTPUT
- name: Create PR
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
Expand All @@ -116,7 +116,7 @@ jobs:
const bumpType = '${{ inputs.type }}';
const newVersion = '${{ steps.version-bumper.outputs.NEW_VERSION }}';
// configure git
// Configure Git
await exec.exec(`git config user.name "github-actions"`);
await exec.exec(`git config user.email "[email protected]"`);
Expand All @@ -131,7 +131,7 @@ jobs:
shouldOpenPullRequest = false;
} catch { }
// add and commit changes
// Add and commit changes
const commitMessage = `Bump ${packageName} version to ${newVersion}`;
const gitCommitCommand = `git commit --all --message "${commitMessage}"`;
let gitCommitOutput = `$ ${gitCommitCommand}\n\n`;
Expand Down

0 comments on commit b09057e

Please sign in to comment.