Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging workflow #18

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Packaging workflow #18

merged 3 commits into from
Sep 16, 2024

Conversation

withinfocus
Copy link
Contributor

🎟️ Tracking

Internal change, to support subsequent work.

📔 Objective

Adds a packaging workflow for PRs and Releases so we can reference NuGet ones made here.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.84%. Comparing base (109353c) to head (b2df6a6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   15.84%   15.84%           
=======================================
  Files          24       24           
  Lines         688      688           
  Branches       54       54           
=======================================
  Hits          109      109           
  Misses        561      561           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 11, 2024

Logo
Checkmarx One – Scan Summary & Detailsa985a83e-4415-411f-8e19-c5e29380bbe1

No New Or Fixed Issues Found

Copy link

@urbinaalex17 urbinaalex17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@withinfocus withinfocus marked this pull request as ready for review September 13, 2024 18:37
@withinfocus withinfocus requested a review from a team as a code owner September 13, 2024 18:37
Copy link

@urbinaalex17 urbinaalex17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@withinfocus withinfocus merged commit c59ec32 into main Sep 16, 2024
13 checks passed
@withinfocus withinfocus deleted the pack-workflow branch September 16, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants