Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #72

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Update README #72

merged 1 commit into from
Oct 10, 2024

Conversation

SaintPatrck
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-13282

๐Ÿ“” Objective

Update QR code and URL in README.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner October 9, 2024 19:49
@SaintPatrck SaintPatrck requested a review from vvolkgang October 9, 2024 19:49
@SaintPatrck SaintPatrck enabled auto-merge (squash) October 9, 2024 19:50
Copy link

github-actions bot commented Oct 9, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ a9143128-7aa9-4887-af05-f2bdf7996964

No New Or Fixed Issues Found

@SaintPatrck SaintPatrck merged commit f9c4b0e into main Oct 10, 2024
5 checks passed
@SaintPatrck SaintPatrck deleted the update-readme branch October 10, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants