Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13283] Add CNAME #74

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[PM-13283] Add CNAME #74

merged 1 commit into from
Oct 10, 2024

Conversation

vvolkgang
Copy link
Member

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-13283

๐Ÿ“” Objective

Required file for GitHub Pages custom domain setup.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested a review from a team as a code owner October 10, 2024 21:08
@vvolkgang vvolkgang enabled auto-merge (squash) October 10, 2024 21:08
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 23992f44-9ec6-405c-ada6-c3cd3ddf4069

No New Or Fixed Issues Found

@vvolkgang vvolkgang merged commit e6c6238 into main Oct 10, 2024
5 checks passed
@vvolkgang vvolkgang deleted the pages-prep branch October 10, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants