Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic index update #91

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Automatic index update #91

merged 2 commits into from
Oct 22, 2024

Conversation

bitwarden-devops-bot
Copy link
Contributor

Index updated to reflect recent changes to the F-Droid repository.

@bitwarden-devops-bot bitwarden-devops-bot requested a review from a team as a code owner October 21, 2024 14:51
@bitwarden-devops-bot bitwarden-devops-bot added the automated pr PR created by workflow or other automation label Oct 21, 2024
Copy link

github-actions bot commented Oct 21, 2024

Logo
Checkmarx One – Scan Summary & Detailsa7de536c-736b-4025-a2b0-c2c1139ab7c7

No New Or Fixed Issues Found

SaintPatrck
SaintPatrck previously approved these changes Oct 21, 2024
@SaintPatrck
Copy link
Contributor

LGTM. @vvolkgang anything stand out to you?

@@ -4,7 +4,7 @@
"en-US": "Bitwarden F-Droid"
},
"description": {
"en-US": "This is a repository of Bitwarden apps to be used with F-Droid. Applications in this repository are official binaries built by Bitwarden."
"en-US": "This is a repository of Bitwarden apps to be used with F-Droid. Applications\nin this repository are official binaries built by Bitwarden.\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these \n expected?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, because we have them in base_fdroid_config.yml. They're not necessary though. We can change the config and they'll be removed on the next scheduled run.

"mirrors": [
{
"url": "https://mobileapp.bitwarden.com/fdroid/repo",
"isPrimary": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n🧊

@@ -49,7 +52,7 @@ Bitwarden is focused on open source software. The source code for Bitwarden is h
<size>71265987</size>
<sdkver>29</sdkver>
<targetSdkVersion>34</targetSdkVersion>
<added>2024-10-16</added>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Now that we have multiple versions it's weird that this isn't using the github release date. I'm guessing it updated now because we changed the url / qrcode?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is generated by the F-Droid tools. It's using the /diffs files to determine the add date. We're not tracking all the diff files every time the F-Droid tools run so it thinks it is new every time.

vvolkgang
vvolkgang previously approved these changes Oct 21, 2024
Index updated to reflect recent changes to the F-Droid repository.
@github-actions github-actions bot dismissed stale reviews from vvolkgang and SaintPatrck via 94ca0eb October 22, 2024 03:04
@SaintPatrck SaintPatrck enabled auto-merge (squash) October 22, 2024 14:55
@SaintPatrck SaintPatrck merged commit 3a54ec2 into main Oct 22, 2024
5 checks passed
@SaintPatrck SaintPatrck deleted the update_fdroid_apps branch October 22, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr PR created by workflow or other automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants