-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic index update #91
Conversation
No New Or Fixed Issues Found |
LGTM. @vvolkgang anything stand out to you? |
@@ -4,7 +4,7 @@ | |||
"en-US": "Bitwarden F-Droid" | |||
}, | |||
"description": { | |||
"en-US": "This is a repository of Bitwarden apps to be used with F-Droid. Applications in this repository are official binaries built by Bitwarden." | |||
"en-US": "This is a repository of Bitwarden apps to be used with F-Droid. Applications\nin this repository are official binaries built by Bitwarden.\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these \n
expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is, because we have them in base_fdroid_config.yml
. They're not necessary though. We can change the config and they'll be removed on the next scheduled run.
"mirrors": [ | ||
{ | ||
"url": "https://mobileapp.bitwarden.com/fdroid/repo", | ||
"isPrimary": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n🧊
@@ -49,7 +52,7 @@ Bitwarden is focused on open source software. The source code for Bitwarden is h | |||
<size>71265987</size> | |||
<sdkver>29</sdkver> | |||
<targetSdkVersion>34</targetSdkVersion> | |||
<added>2024-10-16</added> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Now that we have multiple versions it's weird that this isn't using the github release date. I'm guessing it updated now because we changed the url / qrcode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is generated by the F-Droid tools. It's using the /diffs
files to determine the add date. We're not tracking all the diff files every time the F-Droid tools run so it thinks it is new every time.
Index updated to reflect recent changes to the F-Droid repository.
94ca0eb
2ba3733
to
94ca0eb
Compare
Index updated to reflect recent changes to the F-Droid repository.