BIT-162: Add TODO for PolicyResponseModel.data field

bitwarden · Sep 14, 2023 · 01413ae · 01413ae
1 parent ad5068c
commit 01413ae
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/.swiftlint.yml b/.swiftlint.yml
@@ -2,6 +2,9 @@ analyzer_rules:
   - unused_declaration
   - unused_import
 
+disabled_rules:
+  - todo
+
 opt_in_rules:
   - anonymous_argument_in_multiline_closure
   - attributes
@@ -71,3 +74,12 @@ type_contents_order:
 identifier_name:
   excluded:
     - id
+
+custom_rules:
+  todo_without_jira:
+    name: "TODO without JIRA"
+    regex: "(TODO|TO DO|FIX|FIXME|FIX ME|todo)(?!: BIT-[0-9]{1,})" # "TODO: BIT-123"
+    message: "All TODOs must be followed by a JIRA reference, for example: \"TODO: BIT-123\""
+    match_kinds:
+      - comment
+    severity: warning
diff --git a/BitwardenShared/Core/Vault/Models/Response/PolicyResponseModel.swift b/BitwardenShared/Core/Vault/Models/Response/PolicyResponseModel.swift
@@ -5,6 +5,8 @@ import Foundation
 struct PolicyResponseModel: Codable, Equatable {
     // MARK: Properties
 
+    // TODO: BIT-309 Parse `data` field.
+
     /// Whether the policy is enabled.
     let enabled: Bool