Skip to content

Commit

Permalink
Update config files
Browse files Browse the repository at this point in the history
  • Loading branch information
KatherineInCode committed Oct 16, 2024
1 parent 2e3d142 commit f1718a3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ env:
MINT_PATH: .mint/lib
RESULT_BUNDLE_PATH: build/BitwardenTests.xcresult
SIMULATOR_NAME: ${{ inputs.simulator-name || 'iPhone 15 Pro' }}
SIMULATOR_VERSION: ${{ inputs.simulator-version || '17.0.1' }}
SIMULATOR_VERSION: ${{ inputs.simulator-version || '18.0' }}
XCODE_VERSION: ${{ inputs.xcode-version }}

jobs:
Expand Down
2 changes: 1 addition & 1 deletion Docs/Architecture.md
Original file line number Diff line number Diff line change
Expand Up @@ -320,4 +320,4 @@ Every type containing logic should be tested. Test files should be named `<TypeT

- **Unit**: Unit tests compose the majority of tests in the suite. These are written using [XCTest](https://developer.apple.com/documentation/xctest) assertions and should be used to test all logic portions within a type.
- **View**: In a SwiftUI view test, [ViewInspector](https://github.com/nalexn/ViewInspector) is used to test any user interactions within the view. This is commonly used to assert that tapping a button sends an action or effect to the processor, but it can also be used to test other view interactions.
- **Snapshot**: In addition to using [ViewInspector](https://github.com/nalexn/ViewInspector) to interact with a view under test, [SnapshotTesting](https://github.com/pointfreeco/swift-snapshot-testing) is used to take snapshots of the view to test for visual changes from one test run to another. The resulting snapshot images are stored in the repository and are compared against on future test runs. Any visual differences on future test runs will result in a failing test. Snapshot tests are usually recorded in light mode, dark mode, and with a large dynamic type size. ⚠️ These tests are done using an **iPhone 15 Pro (17.0.1)** simulator, otherwise tests may fail because of subtle differences between iOS versions.
- **Snapshot**: In addition to using [ViewInspector](https://github.com/nalexn/ViewInspector) to interact with a view under test, [SnapshotTesting](https://github.com/pointfreeco/swift-snapshot-testing) is used to take snapshots of the view to test for visual changes from one test run to another. The resulting snapshot images are stored in the repository and are compared against on future test runs. Any visual differences on future test runs will result in a failing test. Snapshot tests are usually recorded in light mode, dark mode, and with a large dynamic type size. ⚠️ These tests are done using an **iPhone 15 Pro (18)** simulator, otherwise tests may fail because of subtle differences between iOS versions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
### Running Tests
Due to slight snapshot test variations between iOS version, the test target requires running in an iPhone 15 Pro simulator (iOS 17.0.1).
Due to slight snapshot test variations between iOS version, the test target requires running in an iPhone 15 Pro simulator (iOS 18).
1. In Xcode's toolbar, select the project and a connected device or simulator.
- The `Generic iOS Device` used for builds will not work for testing.
Expand Down

0 comments on commit f1718a3

Please sign in to comment.