-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS file #10
Conversation
2b761ac
to
cc68200
Compare
We have been discussing different approaches internally (having team folders closer to the root) but, not having any files yet makes the decision process harder. One thing we agree, based on the current structure it will be easy to pivot at a later stage. I'm chasing feedback about the Platform ownership, what you described makes sense but I'm not sure about L10N for instance. Tools also own exporters.
They're the default assignee when new changes don't fall under any defined ownership, that team is then responsible for defining who owns them. It was recently renamed to |
@vvolkgang Updated based on feedback from our meeting today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for the update! 👍🏾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
🚧 Type of change
📔 Objective
Updates the CODEOWNERS file to assign teams based on the expected project structure.
We're planning on using the following project structure. This may evolve and grow as we build out the project, but we'll try to group things based on the team that should be assigned to it.
Open questions:
team-leads-eng
or should every file ideally have an assigned code owner?📋 Code changes
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes