Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14372] Updated SDK reference to a0d9312 #1101

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Oct 31, 2024

🎟️ Tracking

PM-14372

📔 Objective

Update SDK reference to unstable -> a0d9312fc1fc63f146064dae88b0a39cbaf7e0c5 so these SDK changes are included:

Also, updated func sshKeyItemState() -> SSHKeyItemState in CipherView+Update so it takes the appropriate values from the cipher's sshKey.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…7e0c5 which includes making the SSH Key properties non optional and adding the "manage" property into the "Collection". Also updated the SSH key item state creation based on the CIpherView.
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.36%. Comparing base (bc0356a) to head (75f498d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1101   +/-   ##
=======================================
  Coverage   89.36%   89.36%           
=======================================
  Files         677      677           
  Lines       42817    42822    +5     
=======================================
+ Hits        38262    38267    +5     
  Misses       4555     4555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fedemkr fedemkr merged commit 76c7f6e into main Nov 4, 2024
9 checks passed
@fedemkr fedemkr deleted the pm-14372/update-sdk-ssh-keys-properties-not-optional branch November 4, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants