generated from bitwarden/template
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14800] Implement Credential Exchange protocol #1138
Draft
fedemkr
wants to merge
16
commits into
main
Choose a base branch
from
PM-14800/credential-exchange
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No New Or Fixed Issues Found |
# Conflicts: # BitwardenAutoFillExtension/Application/Support/Info.plist
…porting credentials flow.
…e and fixed some warnings.
…BLED compiler flag to a compiler version check.
# Conflicts: # BitwardenShared/Core/Platform/Models/Enum/FeatureFlag.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-14800
📔 Objective
Implement new Credential Exchange protocol for importing/exporting credentials leveraging the Bitwarden SDK for it.
Depends on: bitwarden/sdk-internal#32
#if compiler(>=6.0.3)
to ensure that block of code is only compiled when in the proper version of the compiler/Xcode; this ensures Xcode stable version to continue compiling the project.🔔 How to trigger Export credentials
Settings -> Vault -> Export vault -> File format = Credential exchange -> Export vault
📸 Screenshots
TBD
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes