Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14800] Implement Credential Exchange protocol #1138

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Nov 13, 2024

🎟️ Tracking

PM-14800

📔 Objective

⚠️ This has been replaced by #1198. Leaving this PR opened just for some tests needed for SDK.

Implement new Credential Exchange protocol for importing/exporting credentials leveraging the Bitwarden SDK for it.
Depends on: bitwarden/sdk-internal#32

⚠️ This requires Xcode 16.2 (currently in beta 2). The code has several compiler checks #if compiler(>=6.0.3) to ensure that block of code is only compiled when in the proper version of the compiler/Xcode; this ensures Xcode stable version to continue compiling the project.

🔔 How to trigger Export credentials

Settings -> Vault -> Export vault -> File format = Credential exchange -> Export vault

📸 Screenshots

TBD

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@fedemkr fedemkr added the beta This is a beta bug/feature label Nov 13, 2024
Copy link
Contributor

github-actions bot commented Nov 13, 2024

Logo
Checkmarx One – Scan Summary & Details6f447985-d85d-4b1f-976b-f89c722a4d96

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta This is a beta bug/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant