[PM-15554] Added cipher-key-encryption remote feature flag logic #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c to pass the proper flag to the SDK.
fedemkr
requested review from
matt-livefront,
phil-livefront,
brant-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
# Conflicts: # BitwardenShared/Core/Platform/Models/Enum/FeatureFlag.swift # BitwardenShared/Core/Platform/Models/Enum/FeatureFlagTests.swift
… and updated loadFlags to use the normal async version of that to keep things simple. Also fixes several warnings in the code.
matt-livefront
approved these changes
Dec 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1205 +/- ##
=======================================
Coverage 89.47% 89.48%
=======================================
Files 700 700
Lines 44724 44733 +9
=======================================
+ Hits 40019 40028 +9
Misses 4705 4705 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-15554
📔 Objective
Added
cipher-key-encryptionfeature flag and its logic so cipher key encryption is enabled on the SDK when such flag is enabled and the server version supports this encryption.Default value of the flag is
trueso to work when the configuration doesn't have the flag either because the app hasn't synced the configuration with the new one that has the flag or because the flag gets removed. In such case server version check remains in there to enable/disable the feature.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes