-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autosync Crowdin Translations #1206
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1206 +/- ##
=======================================
Coverage 89.42% 89.42%
=======================================
Files 692 692
Lines 43995 43995
=======================================
Hits 39343 39343
Misses 4652 4652 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
Setting to hold because with this PR it looks like we're losing a bunch of translations? |
@KatherineInCode We did remove the hyphen from "auto-fill" in a bunch of instances which likely invalidates the old translation. #1185 Are those the instances you're referring to? |
@matt-livefront That's what it looks like on second glance, yes. Though it surprises me that it would invalidate the translations if the key remained the same? Might be a weird settings thing. I still think we might want to hold off a moment to give translators a chance to backfill things? |
@KatherineInCode I think it makes sense if you change the base localized value, you may want to update the translated values as well? Android made this change a while ago, I kind of thought we'd get some of their already re-translated strings if updates have been made there (and maybe we did too, hard to say). I'm not opposed to waiting, we may get another update or two from Crowdin before the next release cut though. |
@matt-livefront We also have a discussion going on internally to track down what might be going on here. |
We're moving forward with merging this. |
Autosync the updated translations