Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosync Crowdin Translations #1206

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Autosync Crowdin Translations #1206

merged 1 commit into from
Dec 16, 2024

Conversation

bw-ghapp[bot]
Copy link
Contributor

@bw-ghapp bw-ghapp bot commented Dec 13, 2024

Autosync the updated translations

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.42%. Comparing base (361cc87) to head (d79bd33).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1206   +/-   ##
=======================================
  Coverage   89.42%   89.42%           
=======================================
  Files         692      692           
  Lines       43995    43995           
=======================================
  Hits        39343    39343           
  Misses       4652     4652           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details1e6b62e3-2221-4f53-878b-ebafe22c52e4

No New Or Fixed Issues Found

@KatherineInCode KatherineInCode added the hold This shouldn't be merged yet label Dec 16, 2024
@KatherineInCode
Copy link
Contributor

Setting to hold because with this PR it looks like we're losing a bunch of translations?

@matt-livefront
Copy link
Collaborator

Setting to hold because with this PR it looks like we're losing a bunch of translations?

@KatherineInCode We did remove the hyphen from "auto-fill" in a bunch of instances which likely invalidates the old translation. #1185 Are those the instances you're referring to?

@KatherineInCode
Copy link
Contributor

@matt-livefront That's what it looks like on second glance, yes. Though it surprises me that it would invalidate the translations if the key remained the same? Might be a weird settings thing. I still think we might want to hold off a moment to give translators a chance to backfill things?

@matt-livefront
Copy link
Collaborator

@matt-livefront That's what it looks like on second glance, yes. Though it surprises me that it would invalidate the translations if the key remained the same? Might be a weird settings thing. I still think we might want to hold off a moment to give translators a chance to backfill things?

@KatherineInCode I think it makes sense if you change the base localized value, you may want to update the translated values as well? Android made this change a while ago, I kind of thought we'd get some of their already re-translated strings if updates have been made there (and maybe we did too, hard to say). I'm not opposed to waiting, we may get another update or two from Crowdin before the next release cut though.

@KatherineInCode
Copy link
Contributor

@matt-livefront We also have a discussion going on internally to track down what might be going on here.

@KatherineInCode KatherineInCode removed the hold This shouldn't be merged yet label Dec 16, 2024
@KatherineInCode
Copy link
Contributor

We're moving forward with merging this.

@KatherineInCode KatherineInCode merged commit e73f89d into main Dec 16, 2024
9 checks passed
@KatherineInCode KatherineInCode deleted the crowdin-auto-sync branch December 16, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants