generated from bitwarden/template
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-8216] Update case of URL in various classes and variables #1212
Merged
+452
−451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1212 +/- ##
=======================================
Coverage 89.56% 89.56%
=======================================
Files 709 709
Lines 45082 45082
=======================================
Hits 40378 40378
Misses 4704 4704 ☔ View full report in Codecov by Sentry. |
KatherineInCode
requested review from
matt-livefront,
phil-livefront,
brant-livefront and
a team
as code owners
December 16, 2024 18:42
BitwardenShared/Core/Platform/Services/Stores/AppSettingsStore.swift
Outdated
Show resolved
Hide resolved
matt-livefront
previously approved these changes
Dec 20, 2024
matt-livefront
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8216
📔 Objective
This follows on from PR 1210. Because the Swift API Design Guidelines suggest that "URL" should be capitalized in classes and variables—and we have been inconsistent with that in the past—this attempts to go through and clean up some places where we use "Url" instead of "URL". There are plenty of other places that this does not capture—we can take care of those in a future pass.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes