Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8216] Update case of URL in various classes and variables #1212

Merged
merged 11 commits into from
Jan 9, 2025

Conversation

KatherineInCode
Copy link
Contributor

@KatherineInCode KatherineInCode commented Dec 16, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8216

📔 Objective

This follows on from PR 1210. Because the Swift API Design Guidelines suggest that "URL" should be capitalized in classes and variables—and we have been inconsistent with that in the past—this attempts to go through and clean up some places where we use "Url" instead of "URL". There are plenty of other places that this does not capture—we can take care of those in a future pass.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Logo
Checkmarx One – Scan Summary & Detailsd0650d45-9b5b-4484-89a7-2a3583809d1a

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 95.49550% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.56%. Comparing base (994a021) to head (1322d2f).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
BitwardenShared/UI/Auth/AuthCoordinator.swift 44.44% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1212   +/-   ##
=======================================
  Coverage   89.56%   89.56%           
=======================================
  Files         709      709           
  Lines       45082    45082           
=======================================
  Hits        40378    40378           
  Misses       4704     4704           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KatherineInCode KatherineInCode marked this pull request as ready for review December 16, 2024 18:42
matt-livefront
matt-livefront previously approved these changes Dec 20, 2024
@KatherineInCode KatherineInCode merged commit f50ef9b into main Jan 9, 2025
9 checks passed
@KatherineInCode KatherineInCode deleted the pm-8216/fix-url-casing branch January 9, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants