Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11598] chore: Add version overrides to GitHub Release workflow #1213

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Dec 16, 2024

🎟️ Tracking

PM-11598

📔 Objective

Adds version input overrides to GitHub Release workflows, enabling 🛹 stake holders to continue the release process when the build workflow doesn't provide the version-info file. If nothing is provided we'll fallback to 0.0.0 (0).

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang marked this pull request as ready for review December 16, 2024 19:41
@vvolkgang vvolkgang requested a review from a team as a code owner December 16, 2024 19:41
@vvolkgang vvolkgang enabled auto-merge (squash) December 16, 2024 19:51
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Logo
Checkmarx One – Scan Summary & Detailsa608097c-5b75-4b7f-9369-3e0a63525bf7

No New Or Fixed Issues Found

@vvolkgang vvolkgang merged commit 088c260 into main Dec 17, 2024
7 checks passed
@vvolkgang vvolkgang deleted the github-release-inputs branch December 17, 2024 11:53
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.44%. Comparing base (361cc87) to head (0858cc1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
+ Coverage   89.42%   89.44%   +0.01%     
==========================================
  Files         692      692              
  Lines       43995    44009      +14     
==========================================
+ Hits        39343    39363      +20     
+ Misses       4652     4646       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants