-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-15377: Rolled back review prompt legacy api #1218
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1218 +/- ##
==========================================
- Coverage 89.63% 89.61% -0.03%
==========================================
Files 721 722 +1
Lines 45544 45579 +35
==========================================
+ Hits 40823 40845 +22
- Misses 4721 4734 +13 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
BitwardenShared/UI/Platform/Application/Appearance/Modifiers/ReviewModifier.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Platform/Application/Appearance/Modifiers/ReviewModifier.swift
Outdated
Show resolved
Hide resolved
import StoreKit | ||
import SwiftUI | ||
|
||
/// A view modifier that requests a review when the view appears. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that requests a review when the view appears.
⛏️ It doesn't just happen when the view appears though. Maybe "requests a review when the view appears if eligible."?
…77/display-app-reivew-prompt
🎟️ Tracking
PM-15377
📔 Objective
Environment(\.requestReview).wrappedValue()
was not actually working, so switched back to legacy apiSKStoreReviewController.requestReview()
.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes