Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-15377: Rolled back review prompt legacy api #1218

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

ezimet-livefront
Copy link
Collaborator

@ezimet-livefront ezimet-livefront commented Dec 18, 2024

🎟️ Tracking

PM-15377

📔 Objective

  • the previous Environment(\.requestReview).wrappedValue() was not actually working, so switched back to legacy api SKStoreReviewController.requestReview().

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 53.06122% with 23 lines in your changes missing coverage. Please review.

Project coverage is 89.61%. Comparing base (b409a15) to head (1a3cf40).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lication/Appearance/Modifiers/ReviewModifier.swift 47.50% 21 Missing ⚠️
...hared/UI/Vault/Vault/VaultList/VaultListView.swift 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
- Coverage   89.63%   89.61%   -0.03%     
==========================================
  Files         721      722       +1     
  Lines       45544    45579      +35     
==========================================
+ Hits        40823    40845      +22     
- Misses       4721     4734      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Logo
Checkmarx One – Scan Summary & Details70f62bda-8633-4393-a092-1e88ee01367e

No New Or Fixed Issues Found

import StoreKit
import SwiftUI

/// A view modifier that requests a review when the view appears.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that requests a review when the view appears.

⛏️ It doesn't just happen when the view appears though. Maybe "requests a review when the view appears if eligible."?

@ezimet-livefront ezimet-livefront merged commit 375587e into main Jan 8, 2025
9 checks passed
@ezimet-livefront ezimet-livefront deleted the PM-15377/display-app-reivew-prompt branch January 8, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants