Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-16847: Update inline loading indicators #1258

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented Jan 10, 2025

🎟️ Tracking

PM-16847 - Partial Loading Indicator: My Vault
PM-16848 - Partial loading indicator: View item
PM-16849 - Partial loading indicator: Sends

📔 Objective

Updates the inline loading indicator for the following screens:

  • Vault list
  • Vault group
  • View vault item

The send list was missing a loading indicator, so that was added as well.

📸 Screenshots

loading.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.43%. Comparing base (96e9560) to head (8d359b1).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...red/UI/Tools/Send/Send/SendList/SendListView.swift 84.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1258   +/-   ##
=======================================
  Coverage   89.42%   89.43%           
=======================================
  Files         725      725           
  Lines       45808    45824   +16     
=======================================
+ Hits        40966    40983   +17     
+ Misses       4842     4841    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Logo
Checkmarx One – Scan Summary & Detailsb369c8be-ae89-4a17-9435-a4fbb7a28592

Great job, no security vulnerabilities found in this Pull Request

fedemkr
fedemkr previously approved these changes Jan 13, 2025
.onAppear {
isSpinning = true
withAnimation(.linear(duration: 1).repeatForever(autoreverses: false)) {
isSpinning = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 For my own edification, what's the salient difference between these two?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the previous implicit animation, when the vault list would load I think the search bar ends up moving the spinner as it appears and that was getting picked up in the animation. So the spinner would not only rotate, but it would also move vertically 🙃. Switching to using withAnimation fixed that.

loading.animation.mp4

let needsSync = try await services.vaultRepository.needsSync()

if needsSync, sections.isEmpty {
// If a sync is needed and there's no sends in the user's vault, it could
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ Technically, it would be "there are no sends"

@matt-livefront matt-livefront merged commit 7001f66 into main Jan 14, 2025
9 checks passed
@matt-livefront matt-livefront deleted the matt/PM-16847-loading-views branch January 14, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants