Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15359] Consider Credential Exchange import policies #1262

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Jan 13, 2025

๐ŸŽŸ๏ธ Tracking

PM-15359

๐Ÿ“” Objective

Fail Credential Exchange import if personal ownership policy is enabled.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ fba3bfdc-c0fd-4604-a7d7-46b6cf216ffd

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.46%. Comparing base (75f527b) to head (c22e652).

Files with missing lines Patch % Lines
...Tools/ImportCXP/ImportCXP/ImportCXPProcessor.swift 20.00% 4 Missing โš ๏ธ
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1262   +/-   ##
=======================================
  Coverage   89.46%   89.46%           
=======================================
  Files         732      732           
  Lines       46128    46132    +4     
=======================================
+ Hits        41268    41273    +5     
+ Misses       4860     4859    -1     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant