Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15360] Consider Credential Exchange export policies. #1263

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Jan 13, 2025

🎟️ Tracking

PM-15360

📔 Objective

Fail CXP export if disable personal vault export policy is enabled.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.46%. Comparing base (9205ace) to head (448d184).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1263   +/-   ##
=======================================
  Coverage   89.46%   89.46%           
=======================================
  Files         732      732           
  Lines       46148    46159   +11     
=======================================
+ Hits        41286    41297   +11     
  Misses       4862     4862           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Logo
Checkmarx One – Scan Summary & Details7e91f9c7-778e-4ffd-b8fc-43e02618b486

Great job, no security vulnerabilities found in this Pull Request

Comment on lines 159 to 170
subject.state.showMainButton = false
let task = Task {
await subject.perform(.cancel)
}
defer { task.cancel() }

try await waitForAsync { [weak self] in
guard let self else { return true }
return !coordinator.routes.isEmpty
}

XCTAssertEqual(.dismiss, coordinator.routes.last)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 Could this test be simplified to avoid the extra task and waitFor? It seems like everything in this flow uses async/await so the waitFor might not be necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants