Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16525] Add callout to not close the app while CXP importing. #1264

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1094,3 +1094,4 @@
"ExportFailed" = "Export failed";
"ThereHasBeenAnIssueExportingItems" = "There has been an issue exporting items.";
"AreYouSureYouWantToCancelTheExportProcessQuestionMark" = "Are you sure you want to cancel the export process?";
"PleaseDoNotCloseTheApp" = "Please do not close the app.";
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ struct ImportCXPState: Equatable, Sendable {
case .start:
Localizations.startImportCXPDescriptionLong
case .importing:
""
Localizations.pleaseDoNotCloseTheApp
case let .success(total, _):
Localizations.itemsSuccessfullyImported(total)
case let .failure(message):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class ImportCXPStateTests: BitwardenTestCase {
XCTAssertEqual(subject.message, Localizations.startImportCXPDescriptionLong)

subject.status = .importing
XCTAssertEqual(subject.message, "")
XCTAssertEqual(subject.message, Localizations.pleaseDoNotCloseTheApp)

subject.status = .success(totalImportedCredentials: 1, importedResults: [])
XCTAssertEqual(subject.message, Localizations.itemsSuccessfullyImported(1))
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading