Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16445] Renamed most uses of CXP acronym to CXF #1265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Jan 13, 2025

🎟️ Tracking

PM-16445

📔 Objective

Renamed most uses of CXP (Credential Exchange Protocol) acronym to CXF (Credential Exchange Format) as it's more appropriate as the usage in the app is more about the format than the entire Protocol implementation itself.

Note: This doesn't apply to the feature flags cxp-export-mobile and cxp-import-mobile; so maintained the properties names to match that to be consistent.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.47%. Comparing base (75f527b) to head (144714f).

Files with missing lines Patch % Lines
...denShared/UI/Tools/ImportCXF/ImportCXFModule.swift 0.00% 2 Missing ⚠️
...ools/Repositories/ExportCXFCiphersRepository.swift 0.00% 1 Missing ⚠️
...e/Tools/Repositories/ImportCiphersRepository.swift 0.00% 1 Missing ⚠️
...nShared/UI/Platform/Application/AppProcessor.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1265      +/-   ##
==========================================
+ Coverage   89.46%   89.47%   +0.01%     
==========================================
  Files         732      732              
  Lines       46128    46128              
==========================================
+ Hits        41268    41273       +5     
+ Misses       4860     4855       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details1e055d31-507d-400d-8fef-848aab818ef0

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant