Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16183] Temporarily remove xcbeautify to troubleshoot hanging test runs #1275

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Jan 15, 2025

🎟️ Tracking

PM-16183

📔 Objective

Some test runs are hanging until the runner reaches the timeout limit (e.g. https://github.com/bitwarden/ios/actions/runs/12776029096/). While troubleshooting it I noticed logs weren't correctly ordered, which is due to our testing suit running concurrently and us missing NSUnbufferedIO=YES, per xcbeautify docs (ref.

While setting that flag would help, for the time being we're temporarily removing xcbeautify until we figure what's causing tests to hang.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested a review from a team as a code owner January 15, 2025 21:59
@vvolkgang vvolkgang changed the title [PM-16183Remove xcbeautify to troubleshoot hanging test runs [PM-16183] Temporarily remove xcbeautify to troubleshoot hanging test runs Jan 15, 2025
@vvolkgang vvolkgang enabled auto-merge (squash) January 15, 2025 22:07
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsaa49b94f-17f1-48cf-a0d8-f149c64358dd

Great job, no security vulnerabilities found in this Pull Request

@vvolkgang vvolkgang merged commit 219e1af into main Jan 15, 2025
6 checks passed
@vvolkgang vvolkgang deleted the remove-xcbeautify branch January 15, 2025 22:52
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.41%. Comparing base (abd0593) to head (f844a6a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1275   +/-   ##
=======================================
  Coverage   89.41%   89.41%           
=======================================
  Files         733      733           
  Lines       46253    46253           
=======================================
  Hits        41358    41358           
  Misses       4895     4895           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants