BIT-174: Adds app-wide navigation layer #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-livefront
requested review from
fedemkr,
jubie-livefront and
matt-livefront
|
No New Or Fixed Issues Found |
fedemkr
previously approved these changes
Sep 5, 2023
BitwardenShared/UI/Platform/Application/Utilities/RootNavigator.swift
Outdated
Show resolved
Hide resolved
fedemkr
previously approved these changes
Sep 5, 2023
# Conflicts: # Bitwarden/Application/Support/Info.plist
Code coverageTotal coverage:
|
| File | Coverage |
|---|---|
| Bitwarden/Application/SceneDelegate.swift | 100.00% |
| Bitwarden/Application/main.swift | 100.00% |
| GlobalTestHelpers/MockAppModule.swift | 0.00% |
| GlobalTestHelpers/MockCoordinator.swift | 0.00% |
| GlobalTestHelpers/MockProcessor.swift | 0.00% |
| GlobalTestHelpers/MockRootNavigator.swift | 0.00% |
| GlobalTestHelpers/MockAppModule.swift | 0.00% |
| GlobalTestHelpers/MockCoordinator.swift | 0.00% |
| GlobalTestHelpers/MockProcessor.swift | 0.00% |
| GlobalTestHelpers/MockRootNavigator.swift | 0.00% |
| GlobalTestHelpers/MockAppModule.swift | 0.00% |
| GlobalTestHelpers/MockCoordinator.swift | 0.00% |
| GlobalTestHelpers/MockProcessor.swift | 0.00% |
| GlobalTestHelpers/MockRootNavigator.swift | 0.00% |
Powered by Slather
Generated by 🚫 Danger
matt-livefront
approved these changes
Sep 5, 2023
fedemkr
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BIT-174
🚧 Type of change
📔 Objective
This PR adds the basis for app-wide navigation. This involved adding a
SceneDelegatefor managingAppCoordinatorinitialization and management, migrating the app from a SwiftUI lifecycle to anAppDelegatebased lifecycle, and aRootViewControllerto handle swapping between main screens in the app.📋 Code changes
AppCoordinatorto handle app-wide navigation.StoreandProcessorgeneric orders to match each other.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes