Skip to content

Conversation

vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Sep 1, 2025

🎟️ Tracking

PM-25359

📔 Objective

Similar to #1285, xcbeautify is hiding build logs making it harder to troubleshoot build failures (e.g. exit code 65 which have been since traced back to failures in pre-build scripts).

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.21%. Comparing base (efbc620) to head (299245d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1898      +/-   ##
==========================================
- Coverage   88.64%   85.21%   -3.44%     
==========================================
  Files         810     1004     +194     
  Lines       51124    61007    +9883     
==========================================
+ Hits        45320    51986    +6666     
- Misses       5804     9021    +3217     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vvolkgang vvolkgang changed the title Vvolkgang/remove xcbeautify2 [PM-25359] Remove xcbeautify from build to uncover build failure logs Sep 1, 2025
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Logo
Checkmarx One – Scan Summary & Details320c64e1-3368-4419-9ef0-46d553e4a7d0

Great job! No new security vulnerabilities introduced in this pull request

@vvolkgang vvolkgang marked this pull request as ready for review September 1, 2025 14:31
@vvolkgang vvolkgang requested review from matt-livefront and a team as code owners September 1, 2025 14:31
@vvolkgang vvolkgang enabled auto-merge (squash) September 1, 2025 14:32
@vvolkgang vvolkgang merged commit 0631c73 into main Sep 1, 2025
12 checks passed
@vvolkgang vvolkgang deleted the vvolkgang/remove-xcbeautify2 branch September 1, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants