Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIT-154: Add launch screen #19

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

jubie-livefront
Copy link
Collaborator

NOTE
Colors found here in Figma
Many of the icons can be found here

🎟️ Tracking

BIT-154

🚧 Type of change

  • 🚀 New feature development

📔 Objective

  • Implement a draft of the splash screen.
  • Add icons and colors to the project.

📋 Code changes

  • swiftgen.yml: Assets will now be generated by SwiftGen

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@bitwarden-bot
Copy link

bitwarden-bot commented Sep 6, 2023

Logo
Checkmarx One – Scan Summary & Detailsd1981105-ceed-4748-9292-c224b682808c

No New Or Fixed Issues Found

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

1 Warning
⚠️ Total coverage less than 80%

Code coverage

Total coverage: 47.87%

Powered by Slather

Generated by 🚫 Danger

matt-livefront
matt-livefront previously approved these changes Sep 6, 2023
Copy link
Collaborator

@matt-livefront matt-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎨

fedemkr
fedemkr previously approved these changes Sep 7, 2023
@jubie-livefront jubie-livefront merged commit 64ec8ef into main Sep 12, 2023
@jubie-livefront jubie-livefront deleted the jubie/BIT-154-splash-screen-UI branch September 12, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants