-
Notifications
You must be signed in to change notification settings - Fork 72
[PM-25573] Update CI to xcode 26.0 #1943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great job! No new security vulnerabilities introduced in this pull request |
I do think if we're going to be updating snapshots already, for iOS 26, we should update the device we're using for them to an iPhone 17 Pro. Or are we thinking we'll turn snapshots off for now, make the update to the workflows, and then at a later point deal with turning them all back on? |
@KatherineInCode They'll need to be updated in a future PR yes, disabling tests snapshot tests fornow. Nonetheless went ahead and updated the device simulator name to that! |
3e7ee03
to
1a6f734
Compare
…nto vvolkgang/xcode26-update
…nto vvolkgang/xcode26-update
…branch and fix two tests on iOS 26
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1943 +/- ##
===========================================
- Coverage 88.67% 70.06% -18.62%
===========================================
Files 822 1015 +193
Lines 51782 61628 +9846
===========================================
- Hits 45920 43180 -2740
- Misses 5862 18448 +12586 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ctor bug with a TODO to remove it when it gets fixed.
d6b37f1
…nto vvolkgang/xcode26-update
🎟️ Tracking
PM-25573
📔 Objective
Updating our CI to use Xcode 26. Temporarily disabling snapshot tests while keeping the rest of the test suit functional, they'll be re-enabled after snapshots are updated in a future PR.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes