Skip to content

Conversation

vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Sep 16, 2025

🎟️ Tracking

PM-25573

📔 Objective

Updating our CI to use Xcode 26. Temporarily disabling snapshot tests while keeping the rest of the test suit functional, they'll be re-enabled after snapshots are updated in a future PR.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang changed the title Update to xcode / ios 26 Update to xcode / ios 26.0 Sep 16, 2025
@fedemkr fedemkr changed the title Update to xcode / ios 26.0 [25573 Update to xcode / ios 26.0 Sep 16, 2025
@fedemkr fedemkr changed the title [25573 Update to xcode / ios 26.0 [PM-25573] Update to xcode / ios 26.0 Sep 16, 2025
@vvolkgang vvolkgang marked this pull request as ready for review September 16, 2025 20:35
@vvolkgang vvolkgang requested review from matt-livefront and a team as code owners September 16, 2025 20:35
@vvolkgang vvolkgang added the t:ci Updates to automated workflows label Sep 16, 2025
@vvolkgang vvolkgang changed the title [PM-25573] Update to xcode / ios 26.0 [PM-25573] Update CI to xcode 26.0 Sep 16, 2025
Copy link
Contributor

github-actions bot commented Sep 16, 2025

Logo
Checkmarx One – Scan Summary & Details9a96099e-8336-43a9-a9b1-920476b24ab1

Great job! No new security vulnerabilities introduced in this pull request

@KatherineInCode
Copy link
Contributor

I do think if we're going to be updating snapshots already, for iOS 26, we should update the device we're using for them to an iPhone 17 Pro. Or are we thinking we'll turn snapshots off for now, make the update to the workflows, and then at a later point deal with turning them all back on?

@vvolkgang
Copy link
Member Author

I do think if we're going to be updating snapshots already, for iOS 26, we should update the device we're using for them to an iPhone 17 Pro. Or are we thinking we'll turn snapshots off for now, make the update to the workflows, and then at a later point deal with turning them all back on?

@KatherineInCode They'll need to be updated in a future PR yes, disabling tests snapshot tests fornow. Nonetheless went ahead and updated the device simulator name to that!

@vvolkgang vvolkgang enabled auto-merge (squash) September 16, 2025 20:53
@vvolkgang vvolkgang force-pushed the vvolkgang/xcode26-update branch from 3e7ee03 to 1a6f734 Compare September 17, 2025 15:45
@vvolkgang vvolkgang requested a review from a team as a code owner September 17, 2025 15:45
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.06%. Comparing base (3bd2f8e) to head (3de7315).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1943       +/-   ##
===========================================
- Coverage   88.67%   70.06%   -18.62%     
===========================================
  Files         822     1015      +193     
  Lines       51782    61628     +9846     
===========================================
- Hits        45920    43180     -2740     
- Misses       5862    18448    +12586     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ctor bug with a TODO to remove it when it gets fixed.
@vvolkgang vvolkgang disabled auto-merge September 18, 2025 12:54
fedemkr
fedemkr previously approved these changes Sep 18, 2025
@vvolkgang vvolkgang dismissed stale reviews from KatherineInCode and fedemkr via d6b37f1 September 18, 2025 19:40
@vvolkgang vvolkgang enabled auto-merge (squash) September 18, 2025 19:45
fedemkr
fedemkr previously approved these changes Sep 18, 2025
@vvolkgang vvolkgang merged commit 7657794 into main Sep 19, 2025
13 of 14 checks passed
@vvolkgang vvolkgang deleted the vvolkgang/xcode26-update branch September 19, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:ci Updates to automated workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants