[PM-25859] Update generator screen navigation bar for iOS 26 #1952
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
KatherineInCode
requested review from
matt-livefront and
a team
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1952 +/- ##
==========================================
- Coverage 88.67% 88.64% -0.04%
==========================================
Files 822 822
Lines 51767 51820 +53
==========================================
+ Hits 45905 45936 +31
- Misses 5862 5884 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if #available(iOS 26, *) { | ||
| ZStack(alignment: .top) { | ||
| internalView(geometry: geometry) | ||
| } | ||
| } else { | ||
| VStack(spacing: 0) { | ||
| internalView(geometry: geometry) | ||
| } |
There was a problem hiding this comment.
🤔 Can we use ZStack in both versions? or does it look weird when the same stack is used pre-post iOS 26?
There was a problem hiding this comment.
If you do it with a ZStack older than iOS 26, it would still need to do the VStack in iOS 16 and 15, because some of the necessary APIs to make the ZStack look right (onGeometryChange, contentMargins) don't go back that far. It therefore seemed more logical to me to differentiate at iOS 26 itself, and try to preserve how we did it pre-26 as closely as possible.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-25859
📔 Objective
This updates the Generator screen on iOS 26 to remove the gray background, and also uses a native Segmented Picker instead of a custom one in order to better handle colors and glass transparency.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes