Skip to content

Conversation

vvolkgang
Copy link
Member

🎟️ Tracking

N/A

📔 Objective

After the xcode 26 update our Test workflows have been hitting the 30min timeout limit. When runs are cancelled, we don't get a working .xcresult which blocks our ability to troubleshoot. Increasing the timeout limit and using xlarge runners with the hope that we'll get useful .xcresult files that may help us find a root cause.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested a review from a team as a code owner September 25, 2025 18:45
@vvolkgang vvolkgang added the t:ci Updates to automated workflows label Sep 25, 2025
@vvolkgang vvolkgang enabled auto-merge (squash) September 25, 2025 18:45
Copy link
Contributor

github-actions bot commented Sep 25, 2025

Logo
Checkmarx One – Scan Summary & Detailsb407d8e3-69fd-44a4-ab6c-add6f99cbb52

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.72%. Comparing base (5e0c390) to head (bf1c94c).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1995      +/-   ##
==========================================
- Coverage   81.29%   75.72%   -5.57%     
==========================================
  Files         822     1023     +201     
  Lines       52015    62181   +10166     
==========================================
+ Hits        42285    47088    +4803     
- Misses       9730    15093    +5363     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fedemkr
fedemkr previously approved these changes Sep 25, 2025
@vvolkgang vvolkgang dismissed stale reviews from fedemkr and KatherineInCode via b0b8388 September 29, 2025 13:21
@vvolkgang vvolkgang disabled auto-merge September 29, 2025 13:26
@vvolkgang vvolkgang force-pushed the vvolkgang/bump-test-timeout branch 2 times, most recently from 5eb3fc1 to ac65dc0 Compare September 30, 2025 13:45
@vvolkgang vvolkgang force-pushed the vvolkgang/bump-test-timeout branch from ac65dc0 to 6a65c54 Compare September 30, 2025 14:34
@vvolkgang vvolkgang requested review from matt-livefront and a team as code owners September 30, 2025 14:34
@vvolkgang vvolkgang force-pushed the vvolkgang/bump-test-timeout branch from 6a65c54 to 1894dd0 Compare September 30, 2025 14:34
@vvolkgang vvolkgang force-pushed the vvolkgang/bump-test-timeout branch from cd06a9e to dfe29e3 Compare September 30, 2025 14:56
@vvolkgang vvolkgang force-pushed the vvolkgang/bump-test-timeout branch from 4e3d29b to c1a9004 Compare September 30, 2025 19:19
@vvolkgang vvolkgang force-pushed the vvolkgang/bump-test-timeout branch from 5a85449 to c7f0c2c Compare October 2, 2025 12:30
@vvolkgang vvolkgang force-pushed the vvolkgang/bump-test-timeout branch from 18ea466 to 6fb70a6 Compare October 2, 2025 14:02
@vvolkgang vvolkgang force-pushed the vvolkgang/bump-test-timeout branch from 6598299 to 6b1fa52 Compare October 2, 2025 15:19
@vvolkgang vvolkgang force-pushed the vvolkgang/bump-test-timeout branch 2 times, most recently from f2b68e3 to 9632043 Compare October 2, 2025 15:37
@vvolkgang vvolkgang force-pushed the vvolkgang/bump-test-timeout branch from 9632043 to af60637 Compare October 2, 2025 15:44
@vvolkgang vvolkgang changed the title Increase Test workflow timeout and use xlarge runners to troubleshoot xcode 26 longer execution times [PM-26455] Improve CI runtimes by disabling cpu intensive processes Oct 2, 2025
@vvolkgang vvolkgang enabled auto-merge (squash) October 2, 2025 16:06
test:
name: Test
runs-on: macos-26
timeout-minutes: 30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Do we still want to bump the timeouts, with everything else we're changing to make things lean?

Comment on lines +139 to +145
- name: Output processes
run: |
echo "Sorted by memory usage"
ps -em -o pid,pcpu,pmem,comm | head -n40
echo "--------------------------------"
echo "Sorted by CPU usage"
ps -er -o pid,pcpu,pmem,comm | head -n40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Do we want this in the test-bwa as well?

@vvolkgang vvolkgang merged commit 0b9b9d8 into main Oct 2, 2025
12 checks passed
@vvolkgang vvolkgang deleted the vvolkgang/bump-test-timeout branch October 2, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:ci Updates to automated workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants