Skip to content

Conversation

KatherineInCode
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26184

📔 Objective

This consolidates the icons from the apps' image asset catalogs into an Icons catalog in BitwardenResources, to maintain a more consistent iconography between the two apps. If there were two different icons for the same thing between the apps, I migrated BWA to using the ones from PM. There were also a few icons that were unique to BWA, and they have also been brought in and the names adjusted to match the new convention.

📸 Screenshots

An example with new icons:

Simulator Screenshot - iPhone 17 Pro - 2025-09-29 at 12 40 12

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode marked this pull request as ready for review September 29, 2025 17:43
Copy link
Contributor

github-actions bot commented Sep 29, 2025

Logo
Checkmarx One – Scan Summary & Detailscb86e6a3-8b1e-41c3-8190-3480973c7afe

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 25.71429% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.70%. Comparing base (232ed85) to head (5f106c3).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ared/UI/Vault/ItemList/ItemList/ItemListView.swift 0.00% 6 Missing ⚠️
...uthenticatorShared/UI/Platform/Tabs/TabRoute.swift 0.00% 4 Missing ⚠️
...Platform/Application/Extensions/View+Toolbar.swift 40.00% 3 Missing ⚠️
.../UI/Vault/ItemList/ItemList/ItemListCardView.swift 0.00% 3 Missing ⚠️
...I/Platform/Application/Views/AccessoryButton.swift 0.00% 2 Missing ⚠️
...latform/Application/Views/BitwardenTextField.swift 33.33% 2 Missing ⚠️
...lt/Views/ItemListItemRow/ItemListItemRowView.swift 0.00% 2 Missing ⚠️
...tform/Application/Views/ExpandableHeaderView.swift 0.00% 1 Missing ⚠️
...atform/Application/Views/SearchNoResultsView.swift 0.00% 1 Missing ⚠️
...d/UI/Platform/Settings/Settings/SettingsView.swift 75.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2005      +/-   ##
==========================================
- Coverage   81.33%   75.70%   -5.63%     
==========================================
  Files         825     1017     +192     
  Lines       52136    61905    +9769     
==========================================
+ Hits        42403    46868    +4465     
- Misses       9733    15037    +5304     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KatherineInCode KatherineInCode merged commit 31ac0c4 into main Oct 1, 2025
13 of 14 checks passed
@KatherineInCode KatherineInCode deleted the pm-26184/consolidate-icons branch October 1, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants