Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIT-58: Add Github Actions workflow for caching dependencies #21

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

matt-livefront
Copy link
Collaborator

🎟️ Tracking

BIT-58

🚧 Type of change

  • 🤖 Build/deploy pipeline (DevOps)

📔 Objective

Previously I added a Github Actions workflow for building and testing PRs. This workflow is setup to use cached dependencies, but since we don't yet have a build that runs on the base branch (main) the cache is empty for any initial PR builds.

Adding this workflow will cache dependencies on pushes to main. This cache will then be available for PRs and should improve the run time when testing PRs.

Eventually, we may have some CI automation that runs on main which would likely replace this, but this should help in the meantime.

📋 Code changes

  • cache-dependencies.yml: A Github Actions workflow that runs on pushes to main which caches build dependencies to improve PR build times.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

1 Warning
⚠️ Total coverage less than 80%

Code coverage

Total coverage: 48.09%

Powered by Slather

Generated by 🚫 Danger

@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Detailsc893b516-8370-4b71-bbae-ae2b756e1404

No New Or Fixed Issues Found

Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I'd wait for the review from @bitwarden/dept-devops

@matt-livefront
Copy link
Collaborator Author

LGTM although I'd wait for the review from @bitwarden/dept-devops

@fedemkr @bitwarden/dept-devops It's been a while on this, who can I politely ask for a review?

@joseph-flinn
Copy link

@fedemkr @bitwarden/dept-devops It's been a while on this, who can I politely ask for a review?

@matt-livefront Sorry for the miss on this. My team and I will be more on top of these PRs. If one does slip through the cracks again, the shared Slack channel is closely watched

@matt-livefront
Copy link
Collaborator Author

@fedemkr @bitwarden/dept-devops It's been a while on this, who can I politely ask for a review?

@matt-livefront Sorry for the miss on this. My team and I will be more on top of these PRs. If one does slip through the cracks again, the shared Slack channel is closely watched

@joseph-flinn No problem! Sounds good, thanks for the review!

@matt-livefront matt-livefront merged commit 6d0e4dd into main Sep 15, 2023
@matt-livefront matt-livefront deleted the matt/BIT-58-ci-caching branch September 15, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants