Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused local lint workflow #26

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Delete unused local lint workflow #26

merged 1 commit into from
Sep 11, 2023

Conversation

withinfocus
Copy link
Contributor

@withinfocus withinfocus commented Sep 11, 2023

๐ŸŽŸ๏ธ Tracking

Internal change.

๐Ÿšง Type of change

  • ๐Ÿงน Tech debt (refactoring, code cleanup, dependency upgrades, etc.)

๐Ÿ“” Objective

Removes the NPM setup for staged lint that's not being used here.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@withinfocus withinfocus marked this pull request as ready for review September 11, 2023 15:04
@withinfocus withinfocus requested a review from a team as a code owner September 11, 2023 15:04
@bitwarden-bot
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ be296ea8-4069-45d0-bfae-a3f918b9730f

No New Or Fixed Issues Found

@github-actions
Copy link
Contributor

1 Warning
โš ๏ธ Total coverage less than 80%

Code coverage

Total coverage: 48.61%

Powered by Slather

Generated by ๐Ÿšซ Danger

@withinfocus withinfocus merged commit ca45d50 into main Sep 11, 2023
@withinfocus withinfocus deleted the deletes branch September 11, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants