Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIT-2316: Fix vault timeout never lock migration #639

Merged
merged 1 commit into from
May 14, 2024

Conversation

matt-livefront
Copy link
Collaborator

🎟️ Tracking

BIT-2316

📔 Objective

A few fixes to ensure the never lock vault timeout migrates:

  • Updates the keychain access group used to match the Xamarin/Maui app.
  • Migrates data stored in keychain items from kSecAttrGeneric to kSecValueData, which puts the Xamarin/Maui data in the spot we're expecting it.
  • Xamarin/Maui doesn't store a value in UserDefaults if never lock is selected - so if the vault timeout in UserDefaults is nil we check if there's a never lock key for the user, otherwise we default their timeout to 15 minutes.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented May 10, 2024

2 Warnings
⚠️ Ignoring duplicate libraries: '-lbitwarden_uniffi'
⚠️ BitwardenShared/Core/Platform/Extensions/Bundle+Extensions.swift has less than 80% code coverage

Bitwarden code coverage

Total coverage: 86.43%

File Coverage
BitwardenShared/Core/Auth/Services/KeychainRepository.swift 90.34%
BitwardenShared/Core/Platform/Extensions/Bundle+Extensions.swift 69.57%
BitwardenShared/Core/Platform/Services/MigrationService.swift 98.15%
BitwardenShared/Core/Platform/Services/ServiceContainer.swift 96.30%
BitwardenShared/Core/Platform/Services/StateService.swift 97.36%

Powered by Slather

Generated by 🚫 Danger

Base automatically changed from matt/BIT-2316-migrate-vault-timeout to main May 14, 2024 14:12
@matt-livefront matt-livefront force-pushed the matt/BIT-2316-migrate-vault-timeout-never-lock branch from adf7091 to 000f6f9 Compare May 14, 2024 14:20
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Detailscf88d4ae-81a2-464b-bc50-60fac356fe9e

No New Or Fixed Issues Found

Copy link
Collaborator

@jubie-livefront jubie-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me!

@matt-livefront matt-livefront merged commit 8976c48 into main May 14, 2024
5 checks passed
@matt-livefront matt-livefront deleted the matt/BIT-2316-migrate-vault-timeout-never-lock branch May 14, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants