-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIT-62: Adds the initial project structure #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go! 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!! 🎉 Just a few questions:
🤔 Could GitHub be configured to treat .strings
files as text instead of binary? So that the difference can be seen (like in Root.strings
). I know It may be possible using .gitattributes
(here one way) but open to other alternatives as well.
❓ Also, are custom fonts going to be set up in a different PR? Saw them missing on the Info.plist
files.
847f300
to
0827786
Compare
0827786
to
cdc3301
Compare
@fedemkr Thanks for the tip! This answer on StackOverflow lead me in the right direction. Turns out, Xcode initially created our <FF><FE>/^@*^@ ^@A^@ ^@s^@i^@n^@g^@l^@e^@ ^@s^@t^@r^@i^@n^@g^@s^@ ^@f^@i^@l^@e^@,^@ ^@w^@h^@o^@s^@e^@ ^@t^@i^@t^@l^@e^@ ^@i^@s^@ ^@s^@p^@e^@c^@i^@f^@i^@e^@d^@ ^@i^@n^@ ^@y^@o^@u^@r^@ ^@p^@r^@e^@f^@e^@r^@e^@n^@c^@e^@s^@ ^@s^@c^@h^@e^@m^@a^@.^@ ^@T^@h^@e^@ ^@s^@t^@r^@i^@n^@g^@s^@ ^@f^@i^@l^@e^@s^@ ^@p^@r^@o^@v^@i^@d^@e^@ ^@t^@h^@e^@ ^@l^@o^@c^@a^@l^@i^@z^@e^@d^@ ^@c^@o^@n^@t^@e^@n^@t^@ ^@t^@o^@ ^@d^@i^@s^@p^@l^@a^@y^@ ^@t^@o^@ ^@t^@h^@e^@ ^@u^@s^@e^@r^@ ^@f^@o^@r^@ ^@e^@a^@c^@h^@ ^@o^@f^@ ^@y^@o^@u^@r^@ ^@p^@r^@e^@f^@e^@r^@e^@n^@c^@e^@s^@.^@ ^@*^@/^@
^@
^@"^@V^@e^@r^@s^@i^@o^@n^@"^@ ^@=^@ ^@"^@V^@e^@r^@s^@i^@o^@n^@"^@;^@
^@ After some quick googling, I discovered that when I converted the file from UTF-16 to UTF-8, the extra byte for each character (that is used in UTF-16) was not removed as a part of this conversion, and so our file was then filled with Now we have a clean file that can be previewed in GitHub! 🥳 |
I think the plan is to not use the custom fonts in this rewrite, and to exclusively use the default fonts per platform (San Fransisco and its variants for iOS). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 🚀 Thanks for all the improvements!!
🎟️ Tracking
BIT-62
🚧 Type of change
📔 Objective
This PR adds the initial project structure, dependencies, and supporting files. The additions in this PR include adding new supporting files for all iOS targets, adding SwiftLint and SwiftFormat configuration files, adding supporting setup scripts, adding dependencies, and adding info to the README.
📋 Code changes
Info.plist
and.entitlement
files from the existing files found inbitwarden/mobile
with a few slight modifications to ensure the project builds and runs smoothly⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes