Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16213] feat: Reduce the required fingers to open the debug menu to 1 #966

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Sep 24, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16213

📔 Objective

Currently, the debug menu can be opened by shaking the device or triple tapping with 3 fingers. The latter isn’t possible to do in a Simulator and requires two hands while using a physical device.

This PR addresses that by reducing the number of required fingers to 1.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Sep 24, 2024

Logo
Checkmarx One – Scan Summary & Details0d085953-dd93-4507-a24a-b0130eb1de41

No New Or Fixed Issues Found

@vvolkgang vvolkgang changed the title Reduced debug menu tap gesture to 1 [PM-16213] feat: Reduce the required fingers to open the debug menu to 1 Dec 19, 2024
@vvolkgang vvolkgang marked this pull request as ready for review December 19, 2024 00:19
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.51%. Comparing base (625bbd3) to head (7bcd7ba).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
Bitwarden/Application/SceneDelegate.swift 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
+ Coverage   89.43%   89.51%   +0.07%     
==========================================
  Files         692      699       +7     
  Lines       44080    44556     +476     
==========================================
+ Hits        39423    39884     +461     
- Misses       4657     4672      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants