Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-207 - Remove rc branch logic #160

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

vgrassia
Copy link
Member

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR removes the logic for the rc branch. This project is developed and released very infrequently so the complicated logic for the rc branch is not needed.

Code changes

  • .github/workflows/build.yml: Remove rc and hotfix-rc references.
  • .github/workflows/cleanup-rc-branch.yml: No longer needed.
  • .github/workflows/release.yml: Changed logic from rc branch to main branch.
  • .github/workflows/test.yml: Removed rc and hotfix-rc references.
  • .github/workflows/version-bump.yml: Removed rc branch logic.

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@vgrassia vgrassia self-assigned this Jul 16, 2024
@vgrassia vgrassia requested a review from a team as a code owner July 16, 2024 18:55
@vgrassia vgrassia enabled auto-merge (squash) July 16, 2024 18:55
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (c63a948) to head (1c93bdd).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #160   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         48      48           
  Lines       1786    1786           
  Branches     100     100           
=====================================
  Misses      1786    1786           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Detailsfbd26f86-5ad9-4a8b-b20e-c4fe22e4bab3

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 157 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 109 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 25 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 124 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 116 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 47 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 199 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /clean-up-rc-branch.yml: 21
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 140
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 132
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 215
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 63
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 161
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 125
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 29

@vgrassia vgrassia merged commit 16b4ab6 into main Jul 19, 2024
8 checks passed
@vgrassia vgrassia deleted the bre-207_remove-rc-branch-logic branch July 19, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants